search

pncnmnp / phoenix10.1

Creates personalized radio stations with your own radio jockey!
MIT License
113 stars 6 forks source link

Fix the metadata mismatch #18

Closed pncnmnp closed 1 year ago

pncnmnp commented 1 year ago

Based on Issue #17

See the analysis at: https://github.com/deepjyoti30/ytmdl/issues/272 to understand why this approach is more accurate than the native ytmdl implementation.

ology commented 1 year ago

I didn't test this in different ways - just the latest config and data bits I had. Works perfectly. 👍🏻

pncnmnp commented 1 year ago

@ology, thank you so much, Gene! I will write some relevant unit tests this week, and also tidy it up a bit. I'm optimistic that we can merge this PR by Friday.

pncnmnp commented 1 year ago

LGTM! Tests seem to work. Merging this PR. If we find any future issues, we can open a new issue in the future.