Open dsand opened 2 years ago
OK, be warned that you are not going to like this answer and I shall, probably, end up being unpopular but don't shoot the messenger:
The ability is still there and it works. I've just uploaded 5 targets based upon what you did last night and the records appear in the ObsReqs database table just fine;
This ability to specify observations in multiple filters was handled by the 'File Upload' mechanism. Indeed, it's how I put Peter Milne's 300+ calibration observations (in different filters with different exposure times) in the first place. Check out bigartn:/var/www/ARTN-ORP/instance/files/rts2_calibrations.tsv;
Mike Lundquist also used the 'File Upload' mechanism a lot to upload lots of targets the afternoon of a run (in the past) ... all he did was create 1 target and then cut-and-paste it again and again and edit the filter/exp_time fields;
The problem is that allowing users the ability to create observations in multiple filters via the JavaScript client-side GUI embedded in AORP has broken a lot of stuff as it deals with a new ObsReq2 table and not the original ObsReqs;
Another side effect of using ObsReq2 is that previous submitted observation requests are no longer visible. To take the calibration examples again, there is a 'rts2' user that held Peter's standards etc: % PGPASSWORD=ArTn_520 psql -h localhost -p5432 -d artn -U artn -c "SELECT COUNT() FROM obsreqs WHERE username LIKE '%rts2%';" ... this returned 338 targets but % PGPASSWORD=ArTn_520 psql -h localhost -p5432 -d artn -U artn -c "SELECT COUNT() FROM obsreq2 WHERE username LIKE '%rts2%';" ... returns just 12!
Most route(s) in AORP now point to ObsReq2 not ObsReqs so you won't see the file upload target(s);
Fixing this is a lot of work if you want the file upload to work with ObsReq2.
The simplest solution is to add 2 new route(s) / buttons to "View Legacy Request(s)" and "View All Legacy Request(s)". How that works with the scheduler, though, is a mystery to me.
I don't mind the answer. I know this worked at one point.
We can assign this to @swyatt7, he specifically asked for 'real world' fixes that need to be done. We made a list. This is definitely functionality we want.
A similar use case will occur of gravitational wave follow-up, where there will be ~50-100 galaxy targets we want to upload immediately. its worth asking right now how we want to do that.
From @swyatt7 on May 19 on slack channel:
I’ve also spent a lot of effort further testing the file uploading which is on production now here it only accepts JSON files and the specified format on that webpage.
We should test this new functionality during the next run.
we use to have this capability, I think, but apparently it does not work anymore.
We should be able to upload a file list of targets, with filters, exposure times, etc to AORP.