pndurette / gTTS

Python library and CLI tool to interface with Google Translate's text-to-speech API

http://gtts.readthedocs.org/

MIT License

2.3k stars 362 forks source link

Add connection timeout + misc improvements #440

Closed austin-bowen closed 10 months ago

austin-bowen commented 10 months ago

Primary Changes

Add optional connection timeout, e.g. gTTS("text", timeout=1.2).
- timeout defaults to None, so default behavior is unchanged.

Misc Improvements

Fix bug in _tokenize() where empty tokens were still allowed through.
Replace _len() function with just len(); it is not needed, as Python 2 is no longer supported.
Fix typos.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (dc4ce71) 98.77% compared to head (e83319a) 98.76%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #440 +/- ## ========================================== - Coverage 98.77% 98.76% -0.01% ========================================== Files 13 13 Lines 326 324 -2 ========================================== - Hits 322 320 -2 Misses 4 4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pndurette commented 10 months ago

Wow I had a lot of typos! Thanks a lot for this, and for the cleanup (there's many Py2 recents indeed).

I'll only be able to review more thoroughly after the weekend (earlier perhaps) but very useful addition thank you!

pndurette commented 10 months ago

This has been released! Thanks!

austin-bowen commented 10 months ago

Woo! Thanks 🙌