search

pnedev / comparePlus

Compare plugin for Notepad++
GNU General Public License v3.0
1.01k stars 139 forks source link

Icons not visible with Notepad++ dark theme #261

Closed Eenpersoonscommissie closed 2 years ago

Eenpersoonscommissie commented 3 years ago

Hi, Notepad++ v8.0 introduced the possibility for a dark ui-theme. With is there is an empty space where the compare buttons should be (they are there, but invisible). The rest of the icons (not only native ones) are shown in a light version. Apparently Notepad++ has a way to switch these if light icons are available (like in f.e. Nextcloud you can use name.svg and name-dark.svg as icons).

pryrt commented 3 years ago

specifically, plugin authors need to call NPPM_ADDTOOLBARICON_FORDARKMODE instead of NPPM_ADDTOOLBARICON if Notepad++ v8.0 or newer. (Actually, I don't think it hurts to call both, to keep the plugin compatible with older versions...)

CypherAus commented 3 years ago

The icons are there (invisible) just mouse over and the tip pops up or use the compare menu items as a work around until resolved. The Dark theme is great. Compare is a great plugin!

pnedev commented 3 years ago

Hi @Eenpersoonscommissie ,

I have stopped supporting the ComparePlugin but I have been planing on releasing a new Compare plugin that is a very enhanced descendant of it which will be named ComparePlus. Unfortunately its development is stalled for a very long time now (8 months or so) due to my busy schedule. I will have your request in mind when I continue with the development.

BR

chcg commented 3 years ago

See also https://github.com/notepad-plus-plus/notepad-plus-plus/issues/10131

CennoxX commented 3 years ago

This was a bug on notepad++'s side that affected also other icons, it is fixed with 8.1.4.

pnedev commented 3 years ago

Thanks for the heads-up @CennoxX . I'll consider this issue fixed then.

pnedev commented 2 years ago

Implemented/fixed and will be included in the first ComparePlus plugin release coming in a month or so.