pnedev / comparePlus

Compare plugin for Notepad++
GNU General Public License v3.0
1.01k stars 139 forks source link

Edit history may be comprised after editing during a compare of two edited files. #264

Closed nentrium closed 2 years ago

nentrium commented 3 years ago

Description of the Issue As we all know you can move backwards (ctrl+z) and forwards (ctrl+y) through the edit history for open and edited files. On occasions I may find I want to compare an edited file with another edited file or an open unedited file. If either or both files are changed during the compare and the compare is canceled (ctrl+alt+x) the edit history for one or both files may be lost. This seems be a bit random, may be determined as to which one is the 'first to compare'?? Have noted that sometimes only recent changes remain in history and earlier edits prior to editing during compare are lost. The trigger for this would be to edit one or both files while in compare mode, simple entering and exiting the compare does not appear loose the edit history of either file.

Steps to Reproduce the Issue to save files to temp files and compare the temp files. I'm sure would work, but messy, but would leave the edit history of the original files unchanged as the have not been compared or edited during compare.

Expected Behavior To still have the edit history available after a compare is canceled (ctrl+alt+x) for both files and as far back as would normally be expected ( however far back that is ).

Actual Behavior edit history for the two files compared may be lost. edit history for other open files remains unaffected, as far as I can be sure!

Debug Information Notepad++ v7.9.5 (64-bit) Build time : Mar 21 2021 - 02:13:17 Path : C:\Program Files\Notepad++\notepad++.exe Admin mode : OFF Local Conf mode : OFF OS Name : Windows 7 Home Premium (64-bit) OS Build : 7601.24544 Current ANSI codepage : 1252 Plugins : ComparePlugin.dll HexEditor.dll mimeTools.dll NppConverter.dll NppExport.dll

pnedev commented 3 years ago

Hello @nentrium ,

This is a duplicate of this issue - https://github.com/pnedev/compare-plugin/issues/248 Please read my answer there: https://github.com/pnedev/compare-plugin/issues/248#issuecomment-703175771

Shortly put - it will be fixed in the new plugin first release - ComparePlus (whenever that happens :/)

pnedev commented 2 years ago

Implemented/fixed and will be included in the first ComparePlus plugin release coming in a month or so.