pnedev / comparePlus

Compare plugin for Notepad++
GNU General Public License v3.0
1.01k stars 139 forks source link

comparing two files in NP++ dark mode makes differences unreadable #273

Closed shocked-gamer closed 2 years ago

shocked-gamer commented 2 years ago

Description of the Issue

when dark mode is enabled in the app, the compare plugin still uses the default colors for the white mode. this makes reading the differences very hard to read.

Steps to Reproduce the Issue

  1. go to settings, preferences and enable dark mode
  2. open to text files and press ctrl+alt+c to start the compare
  3. see the highlighted results that are hard to read

Expected Behavior

when enabling dark mode the plugin should auto change it's highlight colors to darker tones or permanently change the colors to darker tones no matter if the user selected white or dark mode.

Debug Information

Notepad++ v8.1.9.3 (64-bit) Build time : Dec 6 2021 - 19:21:37 Capture Capture2

pnedev commented 2 years ago

I'll see what I can do, thanks.

nielsvdc commented 2 years ago

Maybe add an ability to manually change the font color?

And of course it would be super to automatically detect dark mode and change the color settings accordingly.

ageekhere commented 2 years ago

I also have this issue, looking forward to a fix.

pnedev commented 2 years ago

@nielsvdc ,

Maybe add an ability to manually change the font color?

You can change the colors manually by going to the plugin menu and opening its Settings.

The fix will be to make automatic default colors for N++ dark mode.

RFBomb commented 2 years ago

Maybe add an ability to manually change the font color?

You can change the colors manually by going to the plugin menu and opening its Settings.

There is no setting for 'Font Color' in the plugin settings page.

(I had to switch to light mode here to use the diff tool...)

Since all DM does is invert the colors, you should do the same for text if DM is enabled

pnedev commented 2 years ago

Oh, yes, you are right about the font color. It cannot be changed currently. I miss-interpreted the question as it was about the background color, sorry.

mappao commented 2 years ago

Also an option to entirely disable highlight colors (or select "no color" for each color setting option) and leave just icons at left of involved rows would be really appreciated here ;) Thank you

pnedev commented 2 years ago

@mappao ,

Unfortunately that will not be currently possible. You could open another ticket for that request if you like just to have that filed but I cannot promise it will be implemented, sorry.

jocker-il commented 2 years ago

Plugin-admin doesn't show there is a newer version for Compare - so is it better to remove compare and install comparePlus ? I'm using 8.1.8 x64, but no problem updating to newest ofc

Edit: using CP 2.0.1 atm (also - thank you very much for this plugin- it's a life saver :) )

pnedev commented 2 years ago

@jocker-il ,

ComparePlus is Compare successor but it is not officially released yet. It will be new plugin, meaning that you can install both Compare and ComparePlus when it is ready. It will be available through Notepad++ Plugins Admin.

elisimpson commented 2 years ago

Hoping ComparePlus resolves this issue. Back to Light Mode until it's released

pnedev commented 2 years ago

@elisimpson ,

Hoping ComparePlus resolves this issue

It does.

BR

pnedev commented 2 years ago

Implemented/fixed and will be included in the first ComparePlus plugin release coming in a month or so.