search

pnedev / comparePlus

Compare plugin for Notepad++
GNU General Public License v3.0
1.01k stars 139 forks source link

[Enhancement] CompareDocking.ico #300

Closed Yaron10 closed 2 years ago

Yaron10 commented 2 years ago

Hello Pavel,

The CompareDocking.ico is treated as a 16x16 image, and is then re-scaled to 14x14.

Replacing https://github.com/pnedev/compare-plugin/blob/2d6d61e5730e5aac44fd6da4731aee9c879099b8/src/NavDlg/NavDialog.cpp#L225 with

        _data.hIconTab      = (HICON)::LoadImage(GetModuleHandle(TEXT("ComparePlus.dll")),
                MAKEINTRESOURCE(IDB_ICON), IMAGE_ICON, 14, 14, LR_LOADMAP3DCOLORS | LR_LOADTRANSPARENT);

should solve the issue.

I'd also suggest to replace the current icon with this one (its actual image is 14x12).

Thank you.

Enjoy your weekend.

pnedev commented 2 years ago

Hello Yaron,

Changed the icon and the loading as you suggested in commit https://github.com/pnedev/compare-plugin/commit/bbdf362032469f762f62a87e5b66512bdd08d2e8

Thank you! :+1:

BR

Yaron10 commented 2 years ago

Hello Pavel,

Great. 👍

I forgot to mention that the code was taken from NPP Dark-Mode refactoring.

Thank you.

BR