search

pnedev / comparePlus

Compare plugin for Notepad++
GNU General Public License v3.0
1.01k stars 139 forks source link

NavBar still white background while dark mode enabled #301

Open AndnixSH opened 2 years ago

AndnixSH commented 2 years ago

Just a minor bug that ComparePlus NavBar background is still white even dark mode is enabled. I'm using build artifacts 6530c14b Environment: platform=x64; Configuration: Release

image

pnedev commented 2 years ago

Hello @AndnixSH ,

It is fixed with commit https://github.com/pnedev/compare-plugin/commit/626cd7c1e04fbafb1d8378319ee71edc5f32e060 to dev branch. Haven't extensively tested it so it might need some tuning. I'll do it later when I have more time.

BR

AndnixSH commented 2 years ago

Looks OK for now. Just one more little suggestion, the border could be a bit thinner and darker compared to notepad++'s border

image

pnedev commented 2 years ago

I'll check that too, OK, thanks.

pnedev commented 2 years ago

Hi again @AndnixSH ,

Could you try again build https://ci.appveyor.com/project/pnedev/compare-plugin/builds/44268759 ? The gaps should be better there. Thank you.

AndnixSH commented 2 years ago

Looks a lot better but still white line on right side image

pnedev commented 2 years ago

@AndnixSH ,

Could you try again build https://ci.appveyor.com/project/pnedev/compare-plugin/builds/44282397 ? Sorry for these iterations but I cannot properly test because I'm on Wine / Linux.

Could you also try the bigger file (more lines) to be on the left side? On my setup sometimes in that case (if left side pane is bigger that right side one) the vertical middle border line is not displayed below the end of right pane (the shorter one).

Thank you.

Yaron10 commented 2 years ago

Hello Pavel,

Dark-mode is a strange world for me. I don't really know what to expect.

This is the NavBar on Window 10 (https://ci.appveyor.com/project/pnedev/compare-plugin/builds/44282397). תמונה

Thank you.

BR

AndnixSH commented 2 years ago

Mine on WIndows 11. The scrollbar is white too image

Yaron10 commented 2 years ago

Hello again Pavel,

Could you also try the bigger file (more lines) to be on the left side? On my setup sometimes in that case (if left side pane is bigger that right side one) the vertical middle border line is not displayed below the end of right pane (the shorter one).

If I understand you correctly, the issue exists in light-mode as well. תמונה

Tested in NPP LTR.

@AndnixSH,

Apart from the white scrollbar and the white area on the right pane, is everything else OK?

Yaron10 commented 2 years ago

Pavel,

The UI can be really annoying and time consuming. :) Would you like me to ping a plugin author who has implemented a docking panel in dark-mode?

pnedev commented 2 years ago

Hello @Yaron10 and @AndnixSH ,

Yaron, thank you for testing NavBar border in light and dark modes. The missing part of the border line between panes is exactly what I wanted to check :+1:

It is fixed in build https://ci.appveyor.com/project/pnedev/compare-plugin/builds/44291388 .

Would you like me to ping a plugin author who has implemented a docking panel in dark-mode?

I don't think it will be useful in CP case but it won't hurt either so yes, thanks.

@AndnixSH , thank you for the feedback as well. I'll see what I can do regarding the scroll bar but due to time limitations I might leave it as it is for the first release. Sorry about that.

Yaron10 commented 2 years ago

Hello Pavel,

The missing part of the border is fixed. 👍

I don't think it will be useful in CP...

So, with your permission, I won't ping him at this point. :) https://github.com/shriprem/FWDataViz

Thank you for your great work.

BR

pnedev commented 2 years ago

@AndnixSH ,

The quickest fix I was able to do (and that affects only the Scroller background) is this: https://ci.appveyor.com/project/pnedev/compare-plugin/builds/44296232

Could you show me how it looks on Win11 (I don't have such setup) ? Thanks.

AndnixSH commented 2 years ago

@AndnixSH ,

The quickest fix I was able to do (and that affects only the Scroller background) is this: https://ci.appveyor.com/project/pnedev/compare-plugin/builds/44296232

Could you show me how it looks on Win11 (I don't have such setup) ? Thanks.

Scrollbar looks kinda messed lol. And i just noticed another issue. Line numbers become wider, and black background on text editor

image

I can offer remote support for my Win11 VM if possible

Yaron10 commented 2 years ago

Hello Pavel,

Windows 10 (https://github.com/pnedev/compare-plugin/commit/d80b54811d579c0602a2750be5c5a94c3179b800).

תמונה

Thank you.

@AndnixSH,

Line numbers become wider

ComparePlus sets Preferences -> Margins -> Line Number to Constant width and restores your original setting when you "Clear Compare".

pnedev commented 2 years ago

@AndnixSH , @Yaron10 ,

Thanks for testing again. Well, I will postpone scrollbar coloring for the moment and revert to its original form until it is properly customized.

@AndnixSH , As @Yaron10 replied the wider lines number margin is due to making it "static" and big enough to fit the biggest line number. It is configured this way only while you are in compare mode. The "black background" is actually an alignment zone inserted where needed in the files - this is not selectable and editable.

Thank you Yaron :+1:

AndnixSH commented 2 years ago

@pnedev Ok. I was quite confused about black background, but not a problem

I think you should not coloring the scroller manually. Can't you use build-in Windows API to change between dark and light mode? Maybe check source of Npp.

Yaron10 commented 2 years ago

Hello Pavel,

and revert to its original form until it is properly customized.

Did you mean reverting https://github.com/pnedev/compare-plugin/commit/d80b54811d579c0602a2750be5c5a94c3179b800? Or those changes should be kept anyway?

Thanks again for your time and work. 👍

pnedev commented 2 years ago

Hello Yaron,

I will more likely just ignore WM_CTLCOLORSCROLLBAR notification handling. In the future when I fix the proper scrollbar coloring for dark mode I will see which changes are appropriate to be kept and which should be removed.

Thanks. BR

Yaron10 commented 2 years ago

👍 Thank you Pavel.

Yaron10 commented 1 year ago

Hello Pavel,

_Add message NPPMDARKMODESUBCLASSANDTHEME. https://github.com/notepad-plus-plus/notepad-plus-plus/pull/13596#issuecomment-1527750917.

Thank you. BR

pnedev commented 1 year ago

Hello Yaron,

I am not quite aware of the sub-classing concept and where I should add that message and in what circumstances. I will have a look when I get to that. Thanks.

PS. OK, I saw in what circumstances but ozone10's PR first needs to be merged into Notepad++ and then I will check what needs to be added to CP. Thank you again :+1:

BR

Yaron10 commented 1 year ago

Hello Pavel,

I just wanted to add a reference here to that PR. Whenever it's merged and you get back to this issue.

Thank you for your ongoing work and the recent improvements. 👍

BR