search

pnedev / comparePlus

Compare plugin for Notepad++
GNU General Public License v3.0
961 stars 139 forks source link

Increase NavBar preview size on high DPI screens #318

Open byzod opened 1 year ago

byzod commented 1 year ago

ComparePlus_1.0.0 and npp 8.4.4 (x64) Original compare plugin works fine (2.0.2.0)

1

btw is it possible to set the color style of navbar individually? I use a grey background, it works fine with the editor but change indicators are barely visible in navbar 2

pnedev commented 1 year ago

@byzod , Could you please paste here the Notepad++ debug info?

is it possible to set the color style of navbar individually?

It is currently not possible. You could try modifying your diff colors making them more contrasting related to your background color.

byzod commented 1 year ago

@byzod , Could you please paste here the Notepad++ debug info?

Notepad++ v8.4.4   (64-bit)
Build time : Jul 15 2022 - 17:54:42
Path : C:\App\Something\Notepad++\notepad++.exe
Command Line : 
Admin mode : OFF
Local Conf mode : ON
Cloud Config : OFF
OS Name : Windows 10 Home China (64-bit) 
OS Version : 21H2
OS Build : 19044.1889
Current ANSI codepage : 936
Plugins : 
    BetterMultiSelection (1.5)
    ComparePlus (1)
    CSharpRegexTools4Npp (1.1.2)
    EmmetNPP (1.0.2)
    HexEditor (0.9.12)
    JSMinNPP (1.2006)
    mimeTools (2.8)
    nppAutoDetectIndent (2.3)
    NppConverter (4.4)
    NppExport (0.4)
    NppTextViz (0.4.2)
    PythonScript (2)

It is currently not possible. You could try modifying your diff colors making them more contrasting related to your background color.

OK that's an option, but I choose light grey as background is all about for a smaller contrast...but considering that compare result is not always shown, high contrast is acceptable

What's more, is it possible to change the relative size of navbar lines? Resize the navbar winodw didn't help

It looks really small in a 4k monitor, I use 200% dpi scale already. I need to be really close to the screen to tell where those lines are....look how large the pointer is compares to those lines... 1

pnedev commented 1 year ago

@byzod ,

I use 200% dpi scale ...

I think that explains the bad markers. It seems they are not resized properly, I'll check that.

You are right about the NavBar on large monitors. I will consider fixing it but I don't know when I'll have the time to do it so it might take a while.

byzod commented 1 year ago

@byzod ,

I use 200% dpi scale ...

I think that explains the bad markers. It seems they are not resized properly, I'll check that.

You are right about the NavBar on large monitors. I will consider fixing it but I don't know when I'll have the time to do it so it might take a while.

Take your time, it's just a minor visual problem :D

Yaron10 commented 1 year ago

Hello Pavel & @byzod,

Original compare plugin works fine (2.0.2.0).

Pavel,

Any idea what might cause the difference?

Thank you.

pnedev commented 1 year ago

Hello @byzod ,

Please try this build - it will fix the symbols view but unfortunately the images are not resized so they will appear rather small on your 4k display. Could you try and confirm please? Thanks.

Hello @Yaron10 ,

The problem comes from the change of the marker symbols. They used to be XMP and now are RGBA and I forgot to set the RGBA images dimensions. Unfortunately I did not manage to resize those and on monitors with very large DPI they will appear small. If I manage to resize those I will write back.

The NavBar will be fixed sometime in the future.

BR

Yaron10 commented 1 year ago

Hello Pavel,

Thank you for the explanation.

Can't NPP's DPIManager be used? https://github.com/notepad-plus-plus/notepad-plus-plus/blob/6d36d9d398497a6914c64a5804f0400b8bcd6fbd/PowerEditor/src/Parameters.h#L1687

BR

byzod commented 1 year ago

Hello @byzod ,

Please try this build - it will fix the symbols view but unfortunately the images are not resized so they will appear rather small on your 4k display. Could you try and confirm please? Thanks.

I don't know how do download from that site

pnedev commented 1 year ago

I don't know how do download from that site

Sorry about that. This is the 32-bit build. And this is the 64-bit one.

byzod commented 1 year ago

It's working :D I don't quite understand what those icon means though, there're so many new ones :D 1

pnedev commented 1 year ago

@byzod , Good.

The icons are basically the same. The new info is: If you see a small dot on the changed, added or removed symbol it means that the same line also exist somewhere else in the file. If there is no dot then the line is unique in the file. About the moved symbol.... well... what you have attached means that the two lines are actually whole moved block so those two lines appear as a block in the other file. The symbol of the Return line means "start of moved block" while the symbol on the next line means "end of moved block". If the moved block had other lines between those two they would have had different moved symbol - with two vertical hollow dots meaning "part of moved block". A single moved line will have a symbol without the vertical dots.

I'm currently unable to upload an image, sorry about that.

Hello @Yaron10 ,

Just to let you know that I'm already doing in CP DPI scaling of toolbar images which is basically what Notepad++ does in its DPI manager but it doesn't help with margin symbols - those are in hex and need to be re-scaled by Scintilla itself but the corresponding API (SCI_RGBAIMAGESETSCALE) is not working as I expected. Thanks.

BR

byzod commented 1 year ago

@byzod , Good.

The icons are basically the same. The new info is: If you see a small dot on the changed, added or removed symbol it means that the same line also exist somewhere else in the file. If there is no dot then the line is unique in the file. About the moved symbol.... well... what you have attached means that the two lines are actually whole moved block so those two lines appear as a block in the other file. The symbol of the Return line means "start of moved block" while the symbol on the next line means "end of moved block". If the moved block had other lines between those two they would have had different moved symbol - with two vertical hollow dots meaning "part of moved block". A single moved line will have a symbol without the vertical dots.

Cool

Yaron10 commented 1 year ago

Hello Pavel,

👍 Thank you for the explanation.

BR