pnedev / comparePlus

Compare plugin for Notepad++
GNU General Public License v3.0
1.01k stars 139 forks source link

Tab Bar Hide is reset each time compare is done #320

Closed HolterPhylo closed 2 years ago

HolterPhylo commented 2 years ago

Using npp++ v8.4.4 and comparePlus v.1.0.0

Like the title says: Each time I use compare, Settings->Preferences->Tab Bar->Hide is reset and the tabs reappear (I prefer to always use the Document list with no tab visible)

Yaron10 commented 2 years ago

@HolterPhylo,

I can not reproduce that. Could you please post a screenshot of your "Preferences -> General" page?

@pnedev will probably reply next week.

Yaron10 commented 2 years ago

@HolterPhylo,

I suppose you use "Set as First to Compare". It's expected that ComparePlus should display the TabBar in that case. If you use "Compare" (default: compare current and previous tabs), the TabBar will not be displayed.

EDIT: Set as First to Compare. Compare.

Your preference should indeed be restored at this stage.

HolterPhylo commented 2 years ago

Screenshot - 9_16_2022 , 8_58_14 PM

If I do just "Compare" as you suggest: Tabs do not open If I do "Set as First" and then "Compare": Tabs open and do not restore preferences (even after "Clear active compare") Small video to demonstrate: https://user-images.githubusercontent.com/3037251/190834661-ec9d5170-e39e-4b3d-8d47-e9205a94520c.mp4

Yaron10 commented 2 years ago

@HolterPhylo,

You're right.

As I wrote in my previous post: Your preference should indeed be restored at this stage. That is: after "Set as First, Compare" or "Set as First, Clear Compare".

pnedev commented 2 years ago

Hello @HolterPhylo, Hello @Yaron10,

The issue is fixed:

Thank you for the support Yaron :+1:

BR

Yaron10 commented 2 years ago

Hello Pavel,

Thank you for the quick fix. I appreciate it. 👍

BR

HolterPhylo commented 2 years ago

@pnedev,

Thanks, tested and this indeed corrected and even improved ComparePlus (no more tabs appearing) Great!