search

pnedev / comparePlus

Compare plugin for Notepad++
GNU General Public License v3.0
961 stars 139 forks source link

[Minor Enhancement] Use System Cursor #347

Open Yaron10 opened 1 year ago

Yaron10 commented 1 year ago

Hello Pavel,

https://github.com/notepad-plus-plus/notepad-plus-plus/commit/0742410737e2e328234f73502b424025fd368cd2.

When you have some free time.

Thank you very much.

BR

pnedev commented 1 year ago

Hello Yaron,

I am sorry my friend but I really don't understand what you mean. Could you please elaborate? Thank you.

BR

Yaron10 commented 1 year ago

Hello Pavel,

Hovering over a link in the About dialog, you get a custom small cursor (even in 96 DPI). If you replace the URLCtrl files with the new ones used now by NPP, we would get the system cursor. Please see the video in https://github.com/notepad-plus-plus/notepad-plus-plus/pull/12773#issue-1523986559.

Also, the XORMask can be removed and the code is shorter.

Thank you.

BR

pnedev commented 1 year ago

Hello Yaron,

Oh, OK, now I got it, thank you :) Good suggestion but since this improvement is not functional and is really minor I'll keep it with lowest priority.

BR

Yaron10 commented 1 year ago

Hello Pavel,

Sure, it's a mini-minor issue. :)

Thank you.