pnemonic78 / HalachicTimes

Halachic Times
Apache License 2.0
10 stars 2 forks source link

Upon enabling reminders, "Remind on Sunday" et seq. remain grayed out temporarily #120

Closed unforgettableid closed 10 months ago

unforgettableid commented 10 months ago

Steps to reproduce

  1. Open the "Halachic Times" app.
  2. Tap the three dots.
  3. Tap "Settings".
  4. Tap "Halachic Prayer Times".
  5. Tap "Dawn".
  6. Tap "Reminder".
  7. Change the Reminder setting from "Off" to "1 minute before".

Actual results

  1. "Remind on Sunday" through "Remind on Saturday and Yom Tov" all remain disabled (greyed out). To enable them, you must tap the Back button then tap "Dawn" again.

Hoped-for results

  1. I was hoping that "Remind on Sunday" through "Remind on Saturday and Yom Tov" would immediately become usable, as soon as I changed the Reminder setting from "Off" to "1 minute before".

Notes

I'm using Halachic Times 13.17 on an old LG G5 LG-H831 running Android 8.0.0 "Oreo".

Thank you for all the volunteer time and effort you've put into this useful app! It's a kind act of chesed to the community.

pnemonic78 commented 10 months ago

fixed in commit 89cfb15f0dc83aacf0c347b912d80ab208db8669

unforgettableid commented 8 months ago

Appreciated!

Verified fixed in version 13.20.