search

pnemonic78 / HalachicTimes

Halachic Times
Apache License 2.0
10 stars 2 forks source link

shabbos ends opinions #81

Closed yparitcher closed 6 years ago

yparitcher commented 6 years ago

add the ability to select minutes after a differnt zman than the one set for sunset/twilight/nightfall

pnemonic78 commented 6 years ago

I saw your intention, so I just took the bits we really need.

yparitcher commented 6 years ago

Thank you, however i was trying to allow for different opinions between nightfall and shabbos ends, as many in the chabad community use 6 degrees for nightfall and are machmir to 8.5 degrees for shabbos ends

pnemonic78 commented 6 years ago

Ok, will add as extra option...

On 2018 Jul 18, at 4:44, yparitcher notifications@github.com wrote:

Thank you, however i was trying to allow for different opinions between nightfall and shabbos ends, as many in the chabad community use 6 degrees for nightfall and are machmir to 8.5 degrees for shabbos ends

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/pnemonic78/HalachicTimes/pull/81#issuecomment-405781950, or mute the thread https://github.com/notifications/unsubscribe-auth/AHZrigAbcdKwKCSvZdi6Ohe-V-r9Keffks5uHpL8gaJpZM4VE3Zs.

yparitcher commented 6 years ago

fixed in 10b77a1a30ad815d61f9ac707aeb54266635f8b4 thanks