search

pneuvial / c3co

Inferring cancer cell clonality from copy-number data
5 stars 1 forks source link

ROBUSTNESS: upgrade positiveFusedLasso() warning to an error? #39

Open HenrikBengtsson opened 6 years ago

HenrikBengtsson commented 6 years ago

Should the warning "Under-identified problem: more latent features than samples" in positiveFusedLasso() be an error instead?

positiveFusedLasso <- function(Y, Z, lambda, eps=1e-1,
                               max.iter=50, warn=FALSE, verbose=FALSE) {

  ## problem dimensions
  M <- length(Y)
  p <- ncol(Z[[1]])  ## number of subclones/archetypes/latent features

  stopifnot(is.numeric(lambda), length(lambda) == M, length(Z) == M)
  if (p > nrow(Y[[1]])) {
    warning("Under-identified problem: more latent features than samples")
  }
HenrikBengtsson commented 5 years ago

PN 2019-02-18: This should be an error.