Hey guys, great work on this repo. I've enjoyed playing around with the example and the codebase.
Recently I encountered an incorrect type-predicate in the isGeometryNode function. When running the priorityQueue loop, an OctreeGeometryNode would be incorrectly asserted as a PointCloudOctreeGeometryNode which could cause subtle typing bugs.
To fix this I created a common interface IPointCloudGeometryNode that extends the IPointCloudTreeNode interface and adds the geometry specific attributes.
Hey guys, great work on this repo. I've enjoyed playing around with the example and the codebase.
Recently I encountered an incorrect type-predicate in the
isGeometryNodefunction. When running the priorityQueue loop, an OctreeGeometryNode would be incorrectly asserted as a PointCloudOctreeGeometryNode which could cause subtle typing bugs.To fix this I created a common interface IPointCloudGeometryNode that extends the IPointCloudTreeNode interface and adds the geometry specific attributes.