pnext / three-loader

Point cloud loader for ThreeJS, based on the core parts of Potree
Other
201 stars 88 forks source link

How is this library handling Potree 2.0's new license? #74

Open geoff-harper opened 4 years ago

geoff-harper commented 4 years ago

I am using this in a commercial product and I need to know if it will be iterating on 1.7 Potree and their BSD license or how will this work?

fahadm commented 4 years ago

Hi, Right now there are no plans of adding Potree 2.0 support. We are aware of the new Potree 2.0 commercial license which complicates things a bit for us. Although if we add support for Potree 2.0 we will only do so after consulting Markus Schütz and the Potree team.

Best regards

On Thu, Aug 6, 2020, 9:01 PM Geoff Harper notifications@github.com wrote:

I am using this in a commercial product and I need to know if it will be iterating on 1.7 Potree and their BSD license or how will this work?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pnext/three-loader/issues/74, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGJA2ITDBCYKYWWNBXJTUTR7L4X3ANCNFSM4PW4FCOQ .

potree commented 4 years ago

If I'm understanding three-loader right, it is only about loading and rendering point clouds in the Potree format. As of now, the partial commercial license of PotreeConverter 2.0 only applies to using the PotreeConverter 2.0 to build an octree out of a point cloud, but it does not apply to using Potree 1.7 (still bsd 2-clause) to visualize point clouds in PotreeConverter 2.0 format. It's a bit confusing but I wanted to make a distinction between the complete rewrite that PotreeConverter 2.0 is, and the regular update that Potree 1.7 is.

To add some more confusion (sorry about that), the code used to load the PotreeConverter 2.0 format is actually located in Potree repository: modules/Loader_1_8. This loader code for the PotreeConverter 2.0 format is under the same bsd 2-clause license as all of Potree 1.7, no changes there.

fahadm commented 4 years ago

Hey, Thank you for the clarification! Yes, three-loader is only used for actually loading and rendering the point clouds in the potree format.

If I understood everything correctly, then you guys will not have an issue with us loading and rendering the 2.0 format using three-loader.

I will create a milestone for adding Potree 2.0 support then.

potree commented 4 years ago

If I understood everything correctly, then you guys will not have an issue with us loading and rendering the 2.0 format using three-loader.

No issues with that, that's fine. Formats should be open anyway, I'll just have to provide some documentation/specification on it at some point.

charlesritchea commented 1 year ago

Just wanted to point out that PotreeConverter 2.0 has changed back to the BSD 2.0 license