search

pnext / three-loader

Point cloud loader for ThreeJS, based on the core parts of Potree
Other
201 stars 88 forks source link

Unhandled Promise rejection in loadPointCloud #82

Open rooby opened 3 years ago

rooby commented 3 years ago

If the XHR request encounters any kind of errors the promise rejects, but the promise rejections aren't handled. Seems like there are a few places in the code where promise rejections aren't handled.

fahadm commented 3 years ago

Can you provide a minimally reproducible example?

kamilmingulov commented 2 years ago

Loader assumes that Response status is always 200 and attempts to access .json or .buffer both of which can be empty if request failed. I made it fail with 404 requesting nonexistent URL.