search

pnext / three-loader

Point cloud loader for ThreeJS, based on the core parts of Potree
Other
201 stars 88 forks source link

Output directory not built when pulling in from npm #97

Closed geoff-harper closed 3 years ago

geoff-harper commented 3 years ago

Hopefully just a quick clarification. I'm currently running v0.2.3 as I'm locked to three r124.

Screenshot 2021-06-16 145207

This is the directory after a fresh install. The typings value is pointed at build/declarations/index.d.ts in package.json which doesn't exist in my instance. I was wondering why it doesn't come built from npm? Trying to build manually errors out pretty substantially.

Edit: rolled back to 0.2.2 and the declarations dir is back

fahadm commented 3 years ago

Ah, good eye, it seems that whenever I publish via yarn, it omits the directory, if you really need the declarations directory, I can include it in the future.

In the mean time, maybe use 0.2.3-beta.2 which includes the directory and is on r124 ( there is no difference between 0.2.3 and the beta package)

geoff-harper commented 3 years ago

Thanks for the info and quick turn around. I'll give that a go for now and hopefully get up to r128 soon

Higuy8000 commented 3 years ago

@fahadm It seems this is still an issue. I just installed the latest version off of npm, and the build directory is missing the declerations/index.d.ts file, resulting in a Could not find a declaration file for module '@pnext/three-loader'. error when trying to import any classes from the module... unless I'm missing something? (should mention it's missing all declarations, not just index.d.ts - rolling back to 0.2.2 seems fine)

fahadm commented 3 years ago

@Higuy8000 Try using 0.2.5 now, it should include the build directory and declarations. ( or if you want to switch to 0.2.6-beta.1 if you want the latest threeJs r132, I'll test a bit more before promoting it to a full release )