search

pnezis / tucan

An Elixir plotting library on top of VegaLite
https://hexdocs.pm/tucan/Tucan.html
MIT License
153 stars 2 forks source link

Polar Plot #7

Open polvalente opened 10 months ago

polvalente commented 10 months ago

Are polar plots something that would be welcome here? I have this PR open on VegaLite, but with the presence of this higher level library, it might be welcome here instead.

The only thing I'm not sure about is that the higher level API might not support the current structuring of the code.

pnezis commented 10 months ago

Hi @polvalente, polar plots would be definitely welcome here. Probably we would add it to a Tucan.Polar module since they are more specialised.

The code uses VegaLite under the hook, and from a quick look at the current PR the port seems straight forward. You can take a stab on this if you want.

A function for appending layers was already in the plans in order to support some other features of the backlog.

polvalente commented 10 months ago

I believe append_layers would still be accepted in VegaLite, even though they're deprecating VegaLite.Data (@josevalim, can you confirm?)

Having that available, how would we go about bringing that code in? Would it be a line-by-line port, or would it have to be translated into the Tucan API?

I'm also not sure about how part of the API would work with the current code (e.g. coloring only the line layers instead of the grid)

josevalim commented 10 months ago

I believe append_layers would still be accepted in VegaLite, even though they're deprecating VegaLite.Data (@josevalim, can you confirm?)

Correct.

pnezis commented 10 months ago

@polvalente I added append_layers and prepend_layers in order to support layering of horizontal - vertical lines (#10). Will try to add polar plots support into the weekend.