Remove GCC7.1 arithmetic overflow fixup

pnggroup / libpng

LIBPNG: Portable Network Graphics support, official libpng repository

http://libpng.sf.net

Other

1.25k stars 611 forks source link

Remove GCC7.1 arithmetic overflow fixup #520

Closed jbowler closed 7 months ago

jbowler commented 7 months ago

This removes pragmas and the controlling code that quelled warnings generated by GCC7.1 (only) with -Wstrict-overflow=3 and possibly other levels. Tested with GCC13.2, GCC7.1 is no longer the current version of GCC7 (GCC7.5) and GCC7.1 was replaced by GCC7.2 on August 14, 2017.

jbowler commented 7 months ago

The whole block of code is, by code examination, fluff; it's protected by an #if which checks for GCC 7.1 which hasn't been around for ever...

ctruta commented 7 months ago

44 lines deleted from png.c is a good reason to raise two thumbs up 👍 👍

jbowler commented 7 months ago

Almost 1%!