pnggroup / libpng

LIBPNG: Portable Network Graphics support, official libpng repository
http://libpng.sf.net
Other
1.25k stars 611 forks source link

Fix unused platform check and configuration for macOS #529

Closed zixu-w closed 7 months ago

zixu-w commented 7 months ago

In a similar manner as zlib (https://github.com/madler/zlib/pull/895), libpng contains a header configuration that's no longer valid and hasn't been exercised for the macOS target.

This problem has not been noticed until a recent extension in clang (https://github.com/llvm/llvm-project/pull/74676) exposed the issue and broke libpng builds on Apple platforms. The failure can be reproduced now by adding #include <TargetConditionals.h> before the block.

ctruta commented 7 months ago

Thank you very much for making the kind of contribution that I personally like the most: deleting code that should no longer be in there 😛

I landed your commit with your name added to the AUTHORS file, but may I please kindly ask for the native spelling of your name as well? Although that file is in ASCII right now, I want to convert it to Markdown and Unicode, eventually.

zixu-w commented 7 months ago

Thanks for the quick review!

FYI: 王子旭