pnggroup / libpng

LIBPNG: Portable Network Graphics support, official libpng repository
http://libpng.sf.net
Other
1.25k stars 611 forks source link

Cmake Fix broken changes related to /scripts/cmake/ change in 1.6.41 #546

Closed danoli3 closed 6 months ago

danoli3 commented 6 months ago

Changes to CMakeLists.txt

Critical Bug as 1.6.41/1.6.42/1.6.43 cannot compile with this change :

Moved the CMake files (except for the main CMakeLists.txt) to scripts/cmake and moved the list of their contributing authors to scripts/cmake/AUTHORS.md

Screenshot 2024-02-16 at 12 18 27 pm

After proposed changes linking code to correct folder Building now!

Screenshot 2024-02-16 at 1 13 07 pm

Added emscripten WASM target also now works

Screenshot 2024-02-16 at 12 58 52 pm
danoli3 commented 6 months ago

Also congrats on finally getting the pnggroup switched over!

Finally can contribute, Long Live PNG @glennrp

ctruta commented 6 months ago

Many thanks. As I wrote in issue #547, I will apply your fix, but I will make a bunch of modifications of my own on top of it.

May I please kindly ask you to submit a separate PR for the Emscripten port? I may integrate it in the upcoming 1.6.43, or I may not, but I don't want it to be lost. That thing is a completely different issue, and I plan on closing this one after I apply and integrate the CMake fix.

danoli3 commented 6 months ago

Squashed that commit and making other PR for emscripten wasm

ctruta commented 6 months ago

Thanks again @danoli3, I integrated your commit in trunk, even though GitHub doesn't seem to realize it. Both #546 and #547 should be fixed now.