Closed danoli3 closed 6 months ago
Also congrats on finally getting the pnggroup switched over!
Finally can contribute, Long Live PNG @glennrp
Many thanks. As I wrote in issue #547, I will apply your fix, but I will make a bunch of modifications of my own on top of it.
May I please kindly ask you to submit a separate PR for the Emscripten port? I may integrate it in the upcoming 1.6.43, or I may not, but I don't want it to be lost. That thing is a completely different issue, and I plan on closing this one after I apply and integrate the CMake fix.
Squashed that commit and making other PR for emscripten wasm
Thanks again @danoli3, I integrated your commit in trunk, even though GitHub doesn't seem to realize it. Both #546 and #547 should be fixed now.
Changes to CMakeLists.txt
Critical Bug as 1.6.41/1.6.42/1.6.43 cannot compile with this change :
After proposed changes linking code to correct folder Building now!
Added emscripten WASM target also now works