ARM: disable native assembler optimisations

pnggroup / libpng

LIBPNG: Portable Network Graphics support, official libpng repository

http://libpng.sf.net

Other

1.25k stars 611 forks source link

ARM: disable native assembler optimisations #562

Closed jbowler closed 3 months ago

jbowler commented 3 months ago

This change disables assembly of assembler language implementations of ARM Neon optimisations. This only affects older GCC versions; everything else either did nothing or used the GCC "intrinsics".

The change can be explicitly bypassed by defined PNG_ARM_NEON_IMPLEMENTATION or, of course, by just reverting the two lines that have material changes!

Signed-off-by: John Bowler jbowler@acm.org

jbowler commented 3 months ago

@billatarm, @rossburton: please review.

billatarm commented 3 months ago

I think the right approach here is to remove the .S file from compilation when neon intrinsics are natively supported. Give me some time to look at it more.

jbowler commented 3 months ago

Yes; this change is insufficient. See my comments in:

https://github.com/pnggroup/libpng/issues/505