pngwn / MDsveX

A markdown preprocessor for Svelte.
https://mdsvex.pngwn.io
MIT License
2.47k stars 103 forks source link

docs: remove unnecessary call to `escapeSvelte` #636

Closed benmccann closed 3 months ago

benmccann commented 3 months ago

I had it there because it's what I've seen in all the examples around the community, but as @theetrain pointed out, I'm not sure it's actually required. From what I can tell, folks were adopting it because of https://github.com/pngwn/MDsveX/issues/212, but I can't reproduce that issue

changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: 6856848091df0a9e170af7b1fc62210e6ec138af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

pkg-pr-new[bot] commented 3 months ago

commit: 6856848

mdsvex

``` pnpm add https://pkg.pr.new/pngwn/MDsveX/mdsvex@636 ```

pfm-parse

``` pnpm add https://pkg.pr.new/pngwn/MDsveX/pfm-parse@636 ```

svast

``` pnpm add https://pkg.pr.new/pngwn/MDsveX/svast@636 ```

svast-stringify

``` pnpm add https://pkg.pr.new/pngwn/MDsveX/svast-stringify@636 ```

svast-utils

``` pnpm add https://pkg.pr.new/pngwn/MDsveX/svast-utils@636 ```

svelte-parse

``` pnpm add https://pkg.pr.new/pngwn/MDsveX/svelte-parse@636 ```

Open in Stackblitz

benmccann commented 2 months ago

@pngwn is there anything we need to do to get this deployed to the site? looks like the old version is still there: https://mdsvex.pngwn.io/docs#with-shiki