search

pngwn / gradio-imageslider

ImageSlider custom component for gradio.
https://huggingface.co/spaces/pngwn/gradio_imageslider
30 stars 5 forks source link

Imageslider breaks on the new Gradio 5 version #35

Open matemato opened 1 month ago

matemato commented 1 month ago

Hi, love your work!

Is there any chance you will be upgrading your implementation of Imageslider so it works on the new version of Gradio? Currently it doesn't work. I tried with numpy images and the display is just empty (but it still works in gradio 4.44).

Thank you so much and appreciate your work!

MomenSirri commented 1 month ago

I encountered this issue as well. When updating Gradio to a version higher than 4.44, the ImageSlider outputs blank images. This tool is really one of the most important components in all the demos I work on, and I can't exclude it. Thank you for your amazing work, and I hope you'll fix it soon.

ai-anchorite commented 1 week ago

+1 to this. Any app that manipulates images really requires this awesome slider.
Seems a missed opportunity that it isn't built into Gradio 5 already.

That said, i see there's steps detailed below, so i'll give that a go!

image https://github.com/gradio-app/gradio/issues/9463

wbstx commented 1 week ago

+1 to this. Any app that manipulates images really requires this awesome slider. Seems a missed opportunity that it isn't built into Gradio 5 already.

That said, i see there's steps detailed below, so i'll give that a go!

image gradio-app/gradio#9463

Thanks for pointing this out. Unfortunately, after some investigation, I found that this library can't be directly adapted to Gradio 5 due to some missing functions, particularly the normalise_file function, which is no longer available in Gradio 5. I’m currently working on merging this repo to Gradio 5's template (5.3.0). Some progress here, still quite buggy though. CCEE608D-5CBE-4D9D-96E1-8D4D008742B9_1_201_a

pngwn commented 1 week ago

I'm almost done with some updates but unfortunately there is a bug with Gradio's custom component CLI which has delayed finalisation and release.

As soon as I have fixed that I should able to finish off and get this out.

ai-anchorite commented 1 week ago

I'm almost done with some updates but unfortunately there is a bug with Gradio's custom component CLI which has delayed finalisation and release.

As soon as I have fixed that I should able to finish off and get this out.

Very much appreciated.

After working with Gradio5 on a recent video app, it feels a little bad moving back to 4 for image apps. Love those individual resets on the sliders! But ImageSlider is indispensable for displaying background removal or upscaling results etc. So much drama in one component!

pngwn commented 1 week ago

There will be even more drama in the next release too!

TonyDua commented 1 week ago

Need to get an update, thank you for your work @pngwn