search

pnkfelix / larceny-test

test import of trac db
Other
2 stars 0 forks source link

The error codes reported for make-vector and make-procedure are wrong: #341

Open larceny-trac-import opened 11 years ago

larceny-trac-import commented 11 years ago

_Reported by: lth on Sun Nov 21 06:00:00 1999 _ 141 v0.47 (991121 / lth) Priority: low Category: ASSEMBLER / correctness

The error codes reported for make-vector and make-procedure are wrong:

(make-vector -10) Error: make-vector-like: -10 is not an exact nonnegative integer.

(make-procedure -10) Error: make-vector-like: -10 is not an exact nonnegative integer.

See Asm/Sparc/sparcprim-3b.sch: emit-make-vector-like!.

larceny-trac-import commented 11 years ago

Author: pnkfelix This same bug propagated into the other Larceny variants; see e.g. [source:trunk/larceny_src/src/Asm/IAssassin/sassy-instr.sch sassy-instr.sch]: ia86.t_op1_49 and ia86.t_op2_80.

Felix assumes that fixing this is a matter of adding a new couple of exception codes to [source:trunk/larceny_src/src/Rts/except.cfg except.cfg], perhaps named $ex.mkv and $ex.mkproc

larceny-trac-import commented 11 years ago

Author: will Error messages will often report the name of the low-level procedure that detects the error, not the name of the high-level procedure that called the low-level procedure.

This is normal, albeit unesthetic. Changing error messages to refer to the specific high-level procedure would be a higher priority if Larceny were aimed at beginning programmers, but that is not the case.

The great primop cleanup is going to reduce the number of low-level procedures while increasing the number of high-level procedures that call the low-level procedures to do their work. The great primop cleanup will therefore increase the frequency of error messages that refer to low-level procedures instead of high-level.

I am therefore reducing the priority of this ticket to "trivial".