search

pnkraemer / tueplots

Figure sizes, font sizes, fonts, and more configurations at minimal overhead. Fix your journal papers, conference proceedings, and other scientific publications.
https://tueplots.readthedocs.io
MIT License
656 stars 25 forks source link

Adapt "docs" CI action for Python 3.12 #134

Closed timweiland closed 6 months ago

timweiland commented 6 months ago

As referenced in PR #133.

venvs created with Python 3.12 no longer include setuptools, so we need to install it manually.

Let's see if this fixes the CI :)

pnkraemer commented 6 months ago

Hi! Thanks so much for this PR :)

It seems that installing setuptools was not the easy fix we thought it was. Therefore, in #135, I set the doc-build version to 3.9 (and bumped the readthedocs version to 3.9 to match this), because these two version should coincide anyway. Now it all works again.

In a separate PR, all python versions can then be bumped appropriately.

But for now, let's close this PR and merge your ICML contribution! :+1: Thanks a lot @timweiland :star: