search

pnlbwh / dMRIharmonization

Multi-site dMRI harmonization
Other
43 stars 14 forks source link

Expected meanFAstats.txt from the pipeline_test.sh #45

Closed kcho closed 4 years ago

kcho commented 4 years ago

In lib/tests/pipeline_test.sh, the lines that call fa_skeleton_test.py appends stats to ${templatePath}/meanFAstat.txt.

https://github.com/pnlbwh/dMRIharmonization/blob/3b0a48612c31408daa06eb337509ecfdbeddb1f4/lib/tests/pipeline_test.sh#L119-L127

It would be nice to have the expected meanFAstats.txt from calling lib/tests/pipeline_test.sh, so users could compare their test outputs to the expected outputs. Or do you already have this text file saved somewhere in your repository?

tashrifbillah commented 4 years ago

It would be nice to have the expected meanFAstats.txt from calling lib/tests/pipeline_test.sh

There is none. The stats are dependent on study and so we won't have a way of providing expected values. See here to know how would the values look like.

kcho commented 4 years ago

The stats from lib/tests/pipeline_test.sh uses the same set, which is downloaded from the repository.

https://github.com/pnlbwh/dMRIharmonization/blob/3b0a48612c31408daa06eb337509ecfdbeddb1f4/lib/tests/pipeline_test.sh#L42

I thought the outputs from lib/test/pipeline_test.sh should be consistent for every run. Please correct me if this is wrong.

tashrifbillah commented 4 years ago

The expected values are given here.

tashrifbillah commented 4 years ago

Please see https://github.com/pnlbwh/dMRIharmonization/tree/fix-force#1-pipeline :)