pnlbwh / pnlpipe

A Python-based framework for processing anatomical (T1, T2) and diffusion weighted images
Other
12 stars 8 forks source link

python_env/shell.nix confusion #7

Closed tashrifbillah closed 6 years ago

tashrifbillah commented 6 years ago

python_env/shell.nix has python27 in it. Given we are making the pipeline python3.6 compatible, is the above right?

{ pkgs ? import <nixpkgs> {} }:
(pkgs.python27.buildEnv.override {
  extraLibs = builtins.attrValues (import ./_pip_packages.nix {
    inherit (pkgs) fetchurl;
    inherit (pkgs.python27Packages) buildPythonPackage;
 });
}).env

# with import <nixpkgs> {};
# (pkgs.python27.withPackages (ps: [ps.plumbum ps.future ps.numpy ps.pandas ps.ipython readline])).    env

I have a sense that make conda doesn't use shell.nix rather uses environment36.yml. Still, bringing to attention.

ihnorton commented 6 years ago

You can remove shell.nix.