COMP: fix windows build errors

pnlbwh / ukftractography

Other

25 stars 27 forks source link

COMP: fix windows build errors #130

Closed pieper closed 4 years ago

pieper commented 4 years ago

include latest visual studio build tools version in boost build check
remove double-linking of json libs for parameter serializer
force copy of git_version.cc since copy_if_different was not working

https://discourse.slicer.org/t/the-slicerdmri-extension-is-currently-unavailable/12276/21

tashrifbillah commented 4 years ago

@tashrifbillah to test on Windows machine @rmukh to review

tashrifbillah commented 4 years ago

Review and tests pending ... Temporarily merging on @pieper's request ...

TODO: if it breaks, unmerge!

tashrifbillah commented 4 years ago

Quoting @pieper

My PR gets things part way, and I thought it worked for the json double link issue, but when I rebuilt from scratch in release mode I still get the problem and I haven't found a way around it yet.

Jc's suggestion worked on my local build.

tashrifbillah commented 4 years ago

Doesn't look like we gained anything, did we? http://slicer.cdash.org/viewBuildError.php?buildid=1975554

pieper commented 4 years ago

Actually, it did work 👍

The change to turn off the ParameterSerializer only applied to the preview build and this is the link for that build:

http://slicer.cdash.org/buildSummary.php?buildid=1975363

There are still issues with the extension manager that made some of the other builds fail.

tashrifbillah commented 4 years ago

Right! Sorry, I was looking at the stable logs.

Did you mean Linux build failed? http://slicer.cdash.org/buildSummary.php?buildid=1974964

By the way, it doesn't look like preview is built on MAC nightly. I see Windows and Linux logs only.

pieper commented 4 years ago

Yes, the linux build appears to have worked but the upload failed because it was too slow. Not sure about the mac.