search

pnnl / HyperNetX

Python package for hypergraph analysis and visualization.
https://hypernetx.readthedocs.io
Other
500 stars 86 forks source link

adding ABDH generator #121

Closed roman-timo closed 8 months ago

roman-timo commented 10 months ago

added ABCDH model generator a ./hypernetx/utils/ modified class Hypergraph - added method from_abcdh

bonicim commented 10 months ago

Please ignore the GH Workflow failure for Docs. There is a bug in that workflow and I will fix it in a later release.

On the run-tests workflow, it failed our precommit hooks because your code failed our Python formatter check; HNX uses Black for a consistent format. See the Code Quality section of our Readme for instructions on how to format your code locally so that it passes the CI pipeline on Github Workflows.

bonicim commented 10 months ago

Changing destination branch to 'develop'. In the future, please use 'develop' as the destination branch for all future PR's. Thanks in advance.

bkamins commented 10 months ago

@roman-timo - are you planning to port the source code of ABCD-H to Python (so that no integration with Julia is needed?)

brendapraggastis commented 10 months ago

We would prefer to have a separate module with ABCDH generation available both from Python and Julia. Please see hypernetx/algorithms/generative_models.py for examples of how this was done in pure Python.

roman-timo commented 10 months ago

@roman-timo - are you planning to port the source code of ABCD-H to Python (so that no integration with Julia is needed?)

Yes, I'm planning to convert this ABCD-H generator to Python first, so that no issues with Julia integration. It will take some time.. Once it is ready, I will mark this PR as "Ready". Please ignore the "Draft" mode for now :)

Thanks for support!

brendapraggastis commented 8 months ago

@roman-timo Closing until new code is ready.