search

pnnl / HyperNetX

Python package for hypergraph analysis and visualization.
https://hypernetx.readthedocs.io
Other
500 stars 86 forks source link

Support for NetworkX>3.0? #147

Closed wlruys closed 4 months ago

wlruys commented 4 months ago

After updating the deprecated adjacency matrix to graph function (mentioned in https://github.com/pnnl/HyperNetX/issues/146) all tests seem to pass when using NetworkX 3.2.

Are there any other reasons for the conservative <3.0 dependency? Can this be updated?

bonicim commented 4 months ago

@wlruys Thanks for your PR. Regarding the use of an older version of networkx, we are exploring different options to manage and resolve our dependencies (e.g. poetry) and in the process plan to update both our required and optional dependencies.

bonicim commented 4 months ago

@wlruys The develop branch will be updated soon; once done, I will rebase your PR and rerun the CI pipeline so that it passes.

bonicim commented 4 months ago

@wlruys The develop branch just got updated. I tested your branch to make sure that there are no merge conflicts with develop. Can you please rebase your branch to develop and do a force push? Or if you want, if you add me as a collaborator to your forked repo, I can update your PR for you.

wlruys commented 4 months ago

Should be gtg. Thanks! This will be much better than switching networkx versions when making figures :)