pnnl / Quality-Install-Tool

BSD 2-Clause "Simplified" License
1 stars 1 forks source link

Updates to create project-to-installation hierarchy #177

Closed sudhacheran closed 5 months ago

sudhacheran commented 6 months ago

1) Two new pages added (a)Project details page - Input page for installer and the installation address details along with Building photo (b)Project list view. (HOME page) - Lists the projects created by the user 2) store and other components updated to accommodate new fields such as (docId aka projectId) and (jobId aka installationId) 3) Templates updated to removed the project details tab

charliepnnl commented 6 months ago

Issues I found while testing:

charliepnnl commented 6 months ago

Comments from testing the latest version:

I will review the actual code next.

charliepnnl commented 5 months ago

Can you fix the first three errors that appear when you run yarn start? They are related to editor_flexbox.tsx.

charliepnnl commented 5 months ago

The only other issue I see is that there should be horizontal spacing around the the project boxes on the Projects page.

sudhacheran commented 5 months ago

The only other issue I see is that there should be horizontal spacing around the the project boxes on the Projects page.

horizontal spacing added for the list items in the project view

Can you fix the first three errors that appear when you run yarn start? They are related to editor_flexbox.tsx.

This seems to require some time to analyze. I have tried updating React and React-DOM to the latest version 18.2.22, which resolved the issue with Fragments, JSX, and JSXs imports, but it reported new errors with LinkContainer.

charliepnnl commented 5 months ago

I see that the errors having to do with editor_flexbox occur in the main branch also. This is happening because we have not updated the template editor code. These errors should go away if you comment out the line import TemplateEditor from './components/editor' in App.tsx. (Be sure to leave a comment as to why it is not being deleted.)

I suggest reverting the versions of React and React-DOM.