pnnl / building-energy-standards-data

Database of building energy standards data for building energy simulation.
Other
8 stars 3 forks source link

create_openstudio_standards_space_data_json_ashrae_90_1() got an unexpected keyword argument 'osstd_repository_path' #88

Closed jiangyilin123 closed 2 months ago

jiangyilin123 commented 2 months ago

QuickStartGuide says the following code block can be used to generate the space type-related data needed by Openstudio-Standards

import sqlite3
conn = sqlite3.connect('openstudio_standards.db')
from building_energy_standards_data.applications.create_openstudio_standards_json import create_openstudio_standards_space_data_json_ashrae_90_1
for t in ["2004", "2007", "2010", "2013", "2016", "2019"]:
    create_openstudio_standards_space_data_json_ashrae_90_1(conn=conn, version_90_1=t, osstd_repository_path="./")
conn.close()

I have the following error: TypeError: create_openstudio_standards_space_data_json_ashrae_90_1() got an unexpected keyword argument 'osstd_repository_path'

However, create_openstudio_standards_data_json_ashrae_90_1 can take osstd_repository_path and run.

lymereJ commented 2 months ago

@jiangyilin123 - osstd_repository_path is a valid argument to create_openstudio_standards_space_data_json_ashrae_90_1(). How are you running the code that you shared? From a clone of the repository, or, did you install the package using pip?

jiangyilin123 commented 2 months ago

I ran it through a repository clone (develop branch). Not sure if the following screen snap helps:create_db

lymereJ commented 2 months ago

I see, thanks! We'll add that shortly.

jiangyilin123 commented 2 months ago

Hi @lymereJ, I saw the create_openstudio_standards_data_json_ashrae_90_1 been changed, and now take osstd_repository_path as an argument. But this seems not updated to the QuickStart.md .

Issue
lymereJ commented 2 months ago

Thanks! Addressed in #96.