pnnl / building-energy-standards-data

Database of building energy standards data for building energy simulation.
Other
8 stars 3 forks source link

Add Occupant Types Data #97

Closed jiangyilin123 closed 2 months ago

jiangyilin123 commented 2 months ago

Description

Adding the occupant types data into the database aims to capture diverse behavioral patterns and create a representative dataset that enables users to improve the building energy modeling and advance research on dynamic occupant behavior using OpenStudio.

Note that this initial design of the occupant types database focuses specifically on office space types and has not yet been integrated into OpenStudio-Standards yet.

Type of change

Specifically, we add support_occupant_types.py,support_occupant_energy_behavior.py, and support_occupant_energy_behavior.py under database_tables. The JSON files corresponding to these data have also been added. Additionally, we included more schedules in the support_schedules.json, which is used to represent occupant schedules in office buildings. The documents have also been updated to explain the occupant types in the database.

How Has This Been Tested?

Using the existing unit tests and existing functions, we can generate an occupant type dataset, create openstudio.db, export database data into csv or json format, and generate OpenStudio-Standards Data.

Test Configuration:
Python 3.12

Checklist:

jiangyilin123 commented 2 months ago

Hi PNNL team, We have submitted a pull request to add occupant-type data. We updated the documents (Structure. md) to explain our dataset. Is this appropriate? If not, we can have a separate document for this.

lymereJ commented 2 months ago

@jiangyilin123 - Thanks a lot for your submission! Do you need it to be merged before the end of the month? Which version of Black are you using to do the formatting?

jiangyilin123 commented 2 months ago

@jiangyilin123 - Thanks a lot for your submission! Do you need it to be merged before the end of the month? Which version of Black are you using to do the formatting?

Hi. The following is my environment:
black, 24.8.0 (compiled: yes) Python (CPython) 3.12.3

lymereJ commented 2 months ago

We're currently using version 22.12.0 of Black. Are you able to try it with that version?

jiangyilin123 commented 2 months ago

We're currently using version 22.12.0 of Black. Are you able to try it with that version

Hi @lymereJ , it would be ideal to merge this submission by the end of this month as it is our FY24 delivery. If that's not possible, merging it before the next expected official release date is another alternative. Thanks!

jiangyilin123 commented 2 months ago

Hi @lymereJ , I am addressing all other comments. Just need a bit more time.

jiangyilin123 commented 2 months ago

Hi Weili and Jeremy. Thank you for the comments. I made changes based on your comments. However, there are still several mentions of OpenStudio or openstudio-standard in Strucutre.md file, which were written by the original author, so I left them untouched. Please let me know if there are any other changes required. If not, it's ready to be merged.

lymereJ commented 2 months ago

All good, we can address them later! Thanks!