search

pnnl / neuromancer

Pytorch-based framework for solving parametric constrained optimization problems, physics-informed system identification, and parametric model predictive control.
https://pnnl.github.io/neuromancer/
Other
909 stars 119 forks source link

psl examples #52

Open drgona opened 1 year ago

drgona commented 1 year ago

@aarontuor @aaron-tuor @madelynshapiro

The current toml file does not include all the dependencies necessary to run psl examples in: https://github.com/pnnl/neuromancer/tree/master/examples/psl

there are broken notebook examples:

all psl examples lack proper documentation to guide the user through the functionality of the library

There are also broken psl examples in the test folder: https://github.com/pnnl/neuromancer/blob/master/tests/psl/coupled_sys_test.ipynb

Missing dependencies:

Failing tests in: psl\test_directory.py assert os.path.normcase(nm_path1)==os.path.normcase(nm_path2), 'installed neuromancer root directory not the same as test root directory' AssertionError: installed neuromancer root directory not the same as test root directory

I am of strong opinion not to include all these psl_gym dependencies in our base environment. the pygame visualisation should be a separate project independent of Neuromancer for now

madelynshapiro commented 1 year ago

All pslgym code has been removed by #69 . Broken notebook examples are still TODO: