search

pnnl / ruleset-checking-tool

Other
7 stars 5 forks source link

Rule 23-1 logic does not align with Rule Description #1429

Open JacksonJ-KC opened 1 month ago

JacksonJ-KC commented 1 month ago

Rule description:

System 2 and 4 - Electric air-source heat pumps shall be modeled with electric auxiliary heat and an outdoor air thermostat. The systems shall be controlled to energize auxiliary heat only when the outdoor air temperature is less than 40°F. The air-source heat pump shall be modeled to continue to operate while auxiliary heat is energized.

The rule logic does not include any logic pertaining to auxiliary heat. Data elements heatpump_auxilliary_heat_type, and heatpump_auxilliary_heat_high_shutoff_temperature are not used.

KarenWGard commented 1 month ago

good catch. Updated the logic

JacksonJ-KC commented 1 month ago

Can you please point to the update?

KarenWGard commented 1 month ago

Can you please point to the update?

created new pull request