pnnl / ruleset-checking-tool

Other
7 stars 5 forks source link

`get_zone_conditioning_category_dict()` `GET_ZONE_CONDITIONING_CATEGORY_DICT__REQUIRED_FIELDS` #1446

Open JacksonJ-KC opened 1 month ago

JacksonJ-KC commented 1 month ago

The fields listed as required fields for this function are controversial. In several rules we allow design_sensible_cool_capacity and rated_sensible_cool_capacity to be used interchangeably because we are not confident which (or if both) will be able to be populated by RPD generation software.

Are we sure that we want these to be required fields that result in UNDETERMINED via MissingKeyException if any are not defined when get_zone_conditioning_category_dict() is called?

"building": {
        "building_segments[*].heating_ventilating_air_conditioning_systems[*].cooling_system": [
            "design_sensible_cool_capacity"
        ],
        "building_segments[*].heating_ventilating_air_conditioning_systems[*].heating_system": [
            "design_capacity"
        ],
        "building_segments[*].heating_ventilating_air_conditioning_systems[*].preheat_system": [
            "design_capacity"
        ],
        "building_segments[*].zones[*].spaces[*]": [
            "floor_area",
        ],
        "building_segments[*].zones[*].surfaces[*].subsurfaces[*]": [
            "u_factor",
        ],
        "building_segments[*].zones[*].terminals[*]": [
            "served_by_heating_ventilating_air_conditioning_system"
        ],
    }
JacksonJ-KC commented 1 month ago

The definition of cooled space in 90.1 does not make clear if it is referring to design capacity or rated capacity.

cooled space: an enclosed space within a building that is cooled by a cooling system whose sensible output capacity is >=3.4 Btu/h·ft2 of floor area.

claperle commented 1 month ago

@JacksonJ-KC I'm not very familiar with this function but do you think it would be appropriate to use similar logic to what we used for assessing modeled baseline efficiency where we used whichever was available? In other words, if design capacity is available but not rated we use design capacity and vice versa. We would just have to make a decision about which to use if they are both defined.

JacksonJ-KC commented 4 weeks ago

I am thinking that design capacity should be prioritized but I don't have strong supporting arguments or a good feeling for potential pros/cons either way