search

pnnl / ruleset-checking-tool

Other
7 stars 5 forks source link

RCT/YJ/get_building_segment_swh_bat function #1517

Closed yunjoonjung-PNNL closed 1 week ago

yunjoonjung-PNNL commented 3 months ago

This function is NOT ready to be reviewed and is highly dependent on the result of this discussion (https://github.com/open229/ruleset-model-description-schema/issues/264).

Based upon the discussion result and schema update, I'll continuously update this function development. Thanks!

Jiarongx-Xie commented 3 weeks ago

Hi Yun Joon, FYI, Weili left some comments on this function here @yunjoonjung-PNNL

yunjoonjung-PNNL commented 3 weeks ago

I addressed the PR comments and the function is ready to be re-reviewed. Thanks!

yunjoonjung-PNNL commented 2 weeks ago

@Jiarongx-Xie I fixed the logic. I'd appreciate it if you could check if the change was made correctly. Thanks!