pnnl / tesp

Other
39 stars 36 forks source link

Add group_recorder to master_settings.JSON #141

Closed trevorhardy closed 5 months ago

trevorhardy commented 6 months ago

When Jessica added a group_recorder using GLMModifier, she got a warning that "group_recorder" was not a recognized object. This implies it wasn't in the master_setting.json (now glm_classes.json). We need to double-check that it's there and see if we can replicate the warning.

trevorhardy commented 5 months ago

Mitch sees it in glm_classes.json so definitely need to verify that no warning is produced.

trevorhardy commented 5 months ago

@jk1066 will test this on her code that was causing the problem.

jk commented 5 months ago

@trevorhardy who are you?

trevorhardy commented 5 months ago

Ahh, sorry "@" the wrong person in the comments.

jk1066 commented 5 months ago

Tested with modified version of feeder_generator.py, no errors.

         group_recorder_params = {
            'group': 'class=house',
            'name': 'air_temp_recorder',
            'file': 'airtemp.csv',
            'interval': 300,
            'property': 'air_temperature'
            }

        group_recorder_obj = glmMod.add_object('group_recorder', 'air_temp', group_recorder_params)

Output on .glm:

object group_recorder {
  name air_temp;
  group class=house;
  name air_temp_recorder;
  file airtemp.csv;
  interval 300;
  property air_temperature;
}