pnopjp / jmeter-plugins

Apache JMeter plugins for Microsoft Azure
Apache License 2.0
17 stars 13 forks source link

Bytes code #13

Open srikanth-tm opened 1 year ago

kuniteru commented 1 year ago

Are #13 and #14 that you pull requested the same changes?

kuniteru commented 1 year ago

I deeply appreciate your contributions.

How does the user fill in the byte array in the message field? I can't think of an intuitive way for users to enter byte array values.

The message type "Base64 encoded binary" is already provided for the purpose of inputting byte array values. Wouldn't it serve the purpose to use this and fill in the message field with the value of the base64-encoded byte array?

Perhaps you are expecting only a variable of type byte array to be entered in the message field? If so, I would like to know of other common Samplers that have a field where only variables can be entered.

If there is such a Sampler, I would like to merge a pull request from you. If there is no such Sampler, I would like to enter a message as "Base64 encoded binary" with a variable already Base64 encoded in a JSR223 Script such as BeanShell or Groovy, or a byte array variable given to the base64Encode function(https://jmeter-plugins.org/wiki/Functions/#base64Encodesupfont-color-gray-size-1-since-1-2-0-font-sup).

srikanth-tm commented 1 year ago

We need the message needs to changed to bytes. It's different from Base64 encode. I am following the same approach as your, you can provide the value in the messaetype files as string, then the sampler convert into bytes during its execution an

Sent from Outlook for Androidhttps://aka.ms/AAb9ysg


From: Kuniteru Asami @.> Sent: Saturday, April 1, 2023 9:05:38 AM To: pnopjp/jmeter-plugins @.> Cc: Srikanth Mohan @.>; Author @.> Subject: Re: [pnopjp/jmeter-plugins] Bytes code (PR #13)

I deeply appreciate your contributions.

How does the user fill in the byte array in the message field? I can't think of an intuitive way for users to enter byte array values.

The message type "Base64 encoded binary" is already provided for the purpose of inputting byte array values. Wouldn't it serve the purpose to use this and fill in the message field with the value of the base64-encoded byte array?

Perhaps you are expecting only a variable of type byte array to be entered in the message field? If so, I would like to know of other common Samplers that have a field where only variables can be entered.

If there is such a Sampler, I would like to merge a pull request from you. If there is no such Sampler, I would like to enter a message as "Base64 encoded binary" with a variable already Base64 encoded in a JSR223 Script such as BeanShell or Groovy, or a byte array variable given to the base64Encode function(https://jmeter-plugins.org/wiki/Functions/#base64Encodesupfont-color-gray-size-1-since-1-2-0-font-suphttps://urldefense.com/v3/__https://jmeter-plugins.org/wiki/Functions/*base64Encodesupfont-color-gray-size-1-since-1-2-0-font-sup__;Iw!!GF_29dbcQIUBPA!yuElFxTRk6lAwpTMy0eQIfbrn7l491XLjeiahPjNRIuRr-V3CJM1h-0n3A_ZVrdCV7BvMYmxBhuxE_ViFeskhfMqDLw$).

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/pnopjp/jmeter-plugins/pull/13*issuecomment-1492816650__;Iw!!GF_29dbcQIUBPA!yuElFxTRk6lAwpTMy0eQIfbrn7l491XLjeiahPjNRIuRr-V3CJM1h-0n3A_ZVrdCV7BvMYmxBhuxE_ViFeskavZ2Asg$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/A6RVNOR4TTP6JAGQYOTES5DW66PAVANCNFSM6AAAAAAWLRFK7Q__;!!GF_29dbcQIUBPA!yuElFxTRk6lAwpTMy0eQIfbrn7l491XLjeiahPjNRIuRr-V3CJM1h-0n3A_ZVrdCV7BvMYmxBhuxE_ViFeskI1XxPBo$. You are receiving this because you authored the thread.Message ID: @.***>

kuniteru commented 1 year ago

Perhaps your message just before was interrupted in the middle?

I now realize that there may be a bug in the "Base64 encoded binary" code. If this is a glitch, and if it can be fixed so that it works correctly, then your goal may have been achieved with "base64 encoded binary". In that case, please let me investigate further, since you would end up with two types for the same purpose.

srikanth-tm commented 1 year ago

Hi , I am converting the string message to bytes . I don’t need it to be converted to Base64 encode binary. The input I provide is in string datatype and the conversion of the string to bytes happens in the code. Having Base64 encode binary wont solve my purpose and also creates confusion for the users . Pls do let me know if we need more discussion .

Regards, Srikanth

Perhaps your message just before was interrupted in the middle?

I now realize that there may be a bug in the "Base64 encoded binary" code. If this is a glitch, and if it can be fixed so that it works correctly, then your goal may have been achieved with "base64 encoded binary". In that case, please let me investigate further, since you would end up with two types for the same purpose.

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/pnopjp/jmeter-plugins/pull/13*issuecomment-1492835828__;Iw!!GF_29dbcQIUBPA!wPn9eYG7NAzFFMmDKpLWuzQ_Ss1eZGv2RR2TtW_SNgebk2jhi7vymn1yQBVCtZBFTchbb_PiLQtZLP7J9bpn5prRzZY$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/A6RVNOUIYROFR36HVKSUQ73W662EDANCNFSM6AAAAAAWLRFK7Q__;!!GF_29dbcQIUBPA!wPn9eYG7NAzFFMmDKpLWuzQ_Ss1eZGv2RR2TtW_SNgebk2jhi7vymn1yQBVCtZBFTchbb_PiLQtZLP7J9bpn2lMILns$. You are receiving this because you authored the thread.Message ID: @.**@.>>

kuniteru commented 1 year ago

Hi,

Thank you for your patience. I have finally completed the verification of a possible problem with "Base64 encoded binary" and found no problem with it.

You mentioned that you are converting string message to byte, why is that? The "String" message type provided does not meet your requirements?

Or, instead of adding a "Bytes" message type, why not modify the already provided "String" message type as you have written?

kuniteru commented 1 year ago

I had written in a previous comment, "Or, instead of adding a "Bytes" message type, why not modify the already provided "String" message type as you have written?", but this was not possible.

srikanth-tm commented 1 year ago

Yes , you are correct. If we change it , it will change the functionality of string message .

Regards, Srikanth

From: Kuniteru Asami @.> Sent: 12 April 2023 12:42 To: pnopjp/jmeter-plugins @.> Cc: Srikanth Mohan @.>; Author @.> Subject: Re: [pnopjp/jmeter-plugins] Bytes code (PR #13)

I had written in a previous comment, "Or, instead of adding a "Bytes" message type, why not modify the already provided "String" message type as you have written?", but this was not possible.

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/pnopjp/jmeter-plugins/pull/13*issuecomment-1504780090__;Iw!!GF_29dbcQIUBPA!2QCISOsolGp47DIVmObflkq7fLzFRdMsnAWDF1AYjdE7cGGvI72xQg-6SpjVTzMaPv5iROMj41id90K-UdYgqUDofIg$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/A6RVNOQK36N55X2W7OJRPVLXAZIVBANCNFSM6AAAAAAWLRFK7Q__;!!GF_29dbcQIUBPA!2QCISOsolGp47DIVmObflkq7fLzFRdMsnAWDF1AYjdE7cGGvI72xQg-6SpjVTzMaPv5iROMj41id90K-UdYgQcCMFpA$. You are receiving this because you authored the thread.Message ID: @.**@.>>