search

pnp-software / cordetfw

C Implementation of a Software Framework for Service-Oriented Applications with PUS Support
Mozilla Public License 2.0
13 stars 1 forks source link

Creation of new HK reports #97

Closed reimers closed 6 years ago

reimers commented 7 years ago

Maybe there is a flaw in the design. During functional tests we tested following case, which result was not successfully:

1.) Create a new HK report (e.g. with SID = 3) using the TC(3,1) HkCreateCmd 2.) All the checks in the procedure of the Start Action of HkCreateCmd went through as expected (a free slot was found in the RDL, the SID was not taken by another report, etc.) 3.) The new report will be then loaded to the OutLoader

But the HK report does not come to live because the definition was not available in the RDL, if it is afterwards set by the Progress Action of HkCreateCmd. I think we need Node 5 in the procedure of the Start Action of HkCreateCmd to set the definition in the RDL there.

pasetti commented 7 years ago

Yes, indeed! In a recent issue, I identified this error and moved node N5 of the Start Action of HkCreateCmd to the Progress Action of the command. I probably forgot to upload the change, It has now been uploaded. The Progress Action for HkCreateCmd is:

Add the definition of the new report to the RDL, set its enabled status to 'disabled', and set the action outcome to 'completed'

reimers commented 6 years ago

Node N5 was deleted from CrPsCmd3s1Start procedure and the logic moved completely to the progress action of the HkCreateCmd.