pnp-software / fcp-editor

Web-based editor for specifying Flight Control Procedures (FCPs) based on ESA's SCOS-2000 standard.
MIT License
3 stars 1 forks source link

Model Name Check When Saving a Model #29

Closed pasetti closed 2 years ago

pasetti commented 2 years ago

One useful "safety" feature (hopefully not too hard too implement) would be as follows: suppose you have edited a model called "ABC" and you want to save it. Normally, you just overwrite the existing copy of model "ABC" but sometimes, either by mistake or intentionally, you may want to overwrite a different model. In order to avoid mistakes, it would be useful to have a check such that if a user tries to save model "ABC" to a model with a different name "XYZ", then a pop-up appears asking the user to confirm that he really wants to overwrite model "XYZ".

Tomas-M commented 2 years ago

There is already a popup window with confirmation. If user tries to overwrite existing file (diagram), it asks if he wants to overwrite it. I can perhaps change the color of the popup window to red, in cases when user tries to save under a different name. I will implement it and you can see if this is something you want.

Tomas-M commented 2 years ago

Implemented here, please test e36a11162c0f9c7c6553d7c4c8da9dd299f63d5a

I decided to go this way:

Tomas-M commented 2 years ago

Let me know please if this is sufficient for you. Thank you

pasetti commented 2 years ago

Thanks Tomas. I tested the new feature and it looks fine. I therefore proceed to close the ticket.