search

pnp-software / fcp-editor

Web-based editor for specifying Flight Control Procedures (FCPs) based on ESA's SCOS-2000 standard.
MIT License
3 stars 1 forks source link

Types of Diagrams #3

Closed pasetti closed 3 years ago

pasetti commented 3 years ago

The FW Profile Editor has two types of diagrams: State Macbines and Procedures. The FCP Editor only needs the Procedure Diagram. The State Machine part of the FW Profile Editor should be deleted or, if it is simpler, it should simply be kept hidden from the user.

Tomas-M commented 3 years ago

Deletion of the code for State Machines would introduce huge code changes. It is not hard, but if you decide later that some particular modification made to TCP editor can be beneficial for FW Profile Editor too, backporting can be harder. If we keep state machine support in the code, it will be easier to backport some of the new improvements to FW Profile Editor if needed, but on the other hand the code will be unnecessary complicated since state machine code won't be used anywhere.

Most likely it will not be necessary to backport anything, and if such situation arises it will be still doable, so I would suggest to delete the SM code entirely.

pasetti commented 3 years ago

I leave it to you to choose the best option (retaining the SM code and "hiding" the SM features or deleting it). But I agree that it is unlikely that there will be some back-porting from this project to the FW Profile Editor. Hence, deletion seems the best option.

Tomas-M commented 3 years ago

Tried to remove the code and it is not as simple as I thought, involves lots of digging to do it properly, to find all unnecessary functions and so on, so I'll keep the code, SM part will be hidden, but remain there.

pasetti commented 3 years ago

Your proposed approach is fine for me.