search

pnp / List-Formatting

List Formatting Samples for use in SharePoint and Microsoft Lists
https://pnp.github.io/List-Formatting/
MIT License
1.74k stars 833 forks source link

Added new view formatting sample #580

Closed ganesh-sanap closed 2 years ago

ganesh-sanap commented 2 years ago
Q A
Bug fix? no
New sample? yes
Related issues? NA

What's in this Pull Request?

New view formatting sample which can be used to customize the list or compact list layout to highlight selected list item rows using @isSelected token and additionalRowClass property in view formatting.

tecchan1107 commented 2 years ago

Thanks for the sample of the new token @isSelected @ganesh-sanap 😍🤩✨

When I tried it, the background color of the rows changed when selected, but the text color of the Title column didn't change to white as shown in the screenshot. Perhaps the Title column was formatted when this screenshot was taken.

Is it possible to review and fix it? If you have any questions, let me know. I will support you!

ganesh-sanap commented 2 years ago

@tecchan1107 Title column was not formatted when this screenshot was taken. However, I noticed I was using plain Title column without edit menu / ellipses (...).

tecchan1107 commented 2 years ago

@ganesh-sanap I see! However, I think we generally use a title column with an edit menu. Therefore, I was concerned that when people use this sample code, they will wonder why the color of the title column does not change.

How about changing additionalRowClass to use only background color changing, e.g. ms-bgColor-themeLighter?

tecchan1107 commented 2 years ago

I've updated the screenshot and merged this pull request! Thanks for the great new token @isSelected sample and for the update @ganesh-sanap 🤩🙏✨

ganesh-sanap commented 2 years ago

Thanks for helping with PR @tecchan1107!