search

pnp / List-Formatting

List Formatting Samples for use in SharePoint and Microsoft Lists
https://pnp.github.io/List-Formatting/
MIT License
1.71k stars 824 forks source link

Update to the link generated #636

Closed gdk-max closed 1 year ago

gdk-max commented 1 year ago
Q A
Bug fix? no
New sample? no
Improvement? yes

What's in this Pull Request?

The link is now generated differently. With the current change, the code doesn't have to be adapted when used.

Thanks for your contribution! Sharing is caring.

tecchan1107 commented 1 year ago

Thank you for the update and awesome sample @gdk-max 😍🙏✨

I have done the merge, please check the following link. (I made some minor adjustments when merging.) https://github.com/pnp/List-Formatting/tree/master/column-samples/text-hyperlink-long-addresses

Please let me know if you have any questions.

In Japanese, we often have trouble with the number of characters in a link due to the encoding, and this sample helps us a lot!! Once again, thank you so much!!!

tecchan1107 commented 1 year ago

If you are going to add or update more than one sample next time around, it would be helpful if you could create multiple branches and separate the pull requests! If you are using Visual Studio Code, you can create a branch from the location in the following image.

image

The following link may also be helpful. https://code.visualstudio.com/docs/sourcecontrol/overview#_branches-and-tags

If you have any more questions, please feel free to ask me anything!!

gdk-max commented 1 year ago

Hi Tetsuya? Thanks for the tip. I was really trying to do that, but I just can't get my head around git to use it properly. I tried to create multiple pull requests but wasn't aware I first needed to branch the scripts.

I have a few scripts about to be published and I will try to create multiple branches and multiple pull requests.

Love to see your commitment to the community. BIG thanks Geert

On Wed, 25 Jan 2023 at 08:31, Tetsuya Kawahara @.***> wrote:

If you are going to add or update more than one sample next time around, it would be helpful if you could create multiple branches and separate the pull requests! If you are using Visual Studio Code, you can create a branch from the location in the following image.

[image: image] https://user-images.githubusercontent.com/51254139/214503812-480b42a8-393b-4acb-a9f1-5732f8f26640.png

The following link may also be helpful.

https://code.visualstudio.com/docs/sourcecontrol/overview#_branches-and-tags

If you have any more questions, please feel free to ask me anything.

— Reply to this email directly, view it on GitHub https://github.com/pnp/List-Formatting/pull/636#issuecomment-1403203777, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOWOYNKVYVMV4NLTOMUSHP3WUDJF5ANCNFSM6AAAAAAUDPRBVA . You are receiving this because you were mentioned.Message ID: @.***>

--

Geert de Kooter @.*** Tel 0032 485 406 522 http://www.exceltrainer.be