pnp / List-Formatting

List Formatting Samples for use in SharePoint and Microsoft Lists
https://pnp.github.io/List-Formatting/
MIT License
1.71k stars 824 forks source link

Image grid #666

Closed reshmee011 closed 1 year ago

reshmee011 commented 1 year ago
Q A
New sample? yes

What's in this Pull Request?

Instagram familiar layout using Instagram feeds

Thanks for your contribution! Sharing is caring.

tecchan1107 commented 1 year ago

Hi @reshmee011 ! Thank you for another sample🤩🤩✨

I'm thinking of processing this pull request after the following Power Automate side is done, as I think it would be better to centralize the Power Automate flow and documentation in one place, is that ok? I am going to remove the Flow zip file included in this pull request and also change the link to the documentation in the README to the README for PnP's Power Automate. https://github.com/pnp/powerautomate-samples/pull/48

reshmee011 commented 1 year ago

Hi Tetsuya

It's a bit tricky as I have not heard anything relating to my PR to my flow. I will try another route , submit as a template to Microsoft and see how it goes. Then users can just create the flow from an existing template.

Thanks a lot Reshmee

On Tue, 16 May 2023, 04:30 Tetsuya Kawahara, @.***> wrote:

Hi @reshmee011 https://github.com/reshmee011 ! Thank you for another sample🤩🤩✨

I'm thinking of processing this pull request after the following Power Automate side is done, as I think it would be better to centralize the Power Automate flow and documentation in one place, is that ok? I am going to remove the Flow zip file included in this pull request and also change the link to the documentation in the README to the README for PnP's Power Automate. pnp/powerautomate-samples#48 https://github.com/pnp/powerautomate-samples/pull/48

— Reply to this email directly, view it on GitHub https://github.com/pnp/List-Formatting/pull/666#issuecomment-1548925005, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2WMHEUKCB6ZIO54OX7RETXGLYHFANCNFSM6AAAAAAXQ5G6B4 . You are receiving this because you were mentioned.Message ID: @.***>

tecchan1107 commented 1 year ago

@reshmee011 I took the liberty of thinking that it would be better to relate it to the flow... very sorry...😣 Please let me know if there is any progress!

reshmee011 commented 1 year ago

No worries.. May be I can make it a generic grid image layout view formatting sample with any links to Instagram or flow, what do you think ?

tecchan1107 commented 1 year ago

@reshmee011 I think that is a great idea! By making a generic sample, it would be easy to apply it to other things, and it would be a sample that many people would find helpful and use! Of course, I think it could also be applied to lists linked to Instagram!

reshmee011 commented 1 year ago

Hi @tecchan1107

Many thanks for the feedback. I will make it generic then.

Best Regards Reshmee

reshmee011 commented 1 year ago

@tecchan1107 : Hope you are doing well. Apologies for the delay. I have renamed the PR to Image grid and made the sample generic without reliance on the power automate.

tecchan1107 commented 1 year ago

Thank you for the great sample and for the fixes! I have merged them, please check the following link. https://github.com/pnp/List-Formatting/tree/master/view-samples/image-grid

The following tweaks were made when doing the merge. Let me know if you have any questions!

Once again, I apologize for the delay and for my self-serving assumption🙇‍♂