search

pnp / List-Formatting

List Formatting Samples for use in SharePoint and Microsoft Lists
https://pnp.github.io/List-Formatting/
MIT License
1.7k stars 822 forks source link

Menu link button sample #668

Closed reshmee011 closed 1 year ago

reshmee011 commented 1 year ago
Q A
New sample? yes

What's in this Pull Request?

Sample to provide a quick links button style with additional configuration related to width, height and color.

tecchan1107 commented 1 year ago

Hi @reshmee011 ! Thank you for the amazing sample😍😍😍✨

I have made the following modifications to the sample. Please check it when you have time and let me know if you have any questions!

Also, I have one suggestion: how about combining the text color settings in one place? (e.g., the text color should be set only in $FontColor) At the moment, both $Color and $FontColor can be used to set the text color, and when it comes time to set the text color, it seems to be a bit confusing as to which one to set.

reshmee011 commented 1 year ago

@tecchan1107 : I have removed the color to set the font color to use fontColor to set font color. Your suggested changes improved the code:)

tecchan1107 commented 1 year ago

Thanks for the update @reshmee011 ! I will do some more testing, tweaking, etc. and merge it in soon. Sorry for the delay🙇‍♂

reshmee011 commented 1 year ago

Hi @tecchan1107 , no worries. Thanks for making the time for further testing and tweaking:)

tecchan1107 commented 1 year ago

@reshmee011 I have done the merge, please check the following link! (I made some minor adjustments when merging.) https://github.com/pnp/List-Formatting/tree/master/view-samples/menu-link-button

Please let me know if you have any questions!

Once again, thank you for the great sample😍😍🙏✨

reshmee011 commented 1 year ago

@tecchan1107 : thank you for the amazing review and updates. I am very happy with my first PR being merged.