search

pnp / List-Formatting

List Formatting Samples for use in SharePoint and Microsoft Lists
https://pnp.github.io/List-Formatting/
MIT License
1.7k stars 822 forks source link

Starred items #674

Closed wwcoop closed 1 year ago

wwcoop commented 1 year ago
Q A
Bug fix? no
New sample? yes
Related issues? None

What's in this Pull Request?

This is my first submission to pnp/List-Formatting. Please advise if I am doing any steps wrong. Thanks!

tecchan1107 commented 1 year ago

Hi @wwcoop ! Thank you for the amazing sample!

However, I don't know the cause, but looking at the commits and changed files, this pull request contains commits from other users😢 image

Ideally, there should be only your own commits and changes to the sample files. Sample pull request image

Could you create a new branch from master and try the pull request again?

wwcoop commented 1 year ago

Yes - let me try again. I am BRAND NEW to Github and very confused by it. Thanks for your patience!

tecchan1107 commented 1 year ago

@wwcoop Please let me know if there is anything you don't understand or stumble upon in making a pull request!

tecchan1107 commented 1 year ago

I'm sorry. I don't speak and hear English very well, so it's difficult for me😢 Just took a look at the branch "starred-items-and-docs" and it looks perfect! Could you try a pull request for it? image

tecchan1107 commented 1 year ago

I will close this pull request! Also, comments with links to the meeting will be deleted for good measure!