Student & Class Learning Tracker & Exam Bundle Tracker (v1)

pnp / List-Formatting

List Formatting Samples for use in SharePoint and Microsoft Lists

https://pnp.github.io/List-Formatting/

MIT License

1.7k stars 822 forks source link

Student & Class Learning Tracker & Exam Bundle Tracker (v1) #687

Closed z3019494 closed 11 months ago

z3019494 commented 12 months ago

Q	A
Bug fix?	No
New sample?	Yes
Related issues?	None

What's in this Pull Request?

Submitting a new sample for the Student and Class Learning Tracker.

Guidance

You can delete this section when you are submitting the pull request.

Please update this PR information accordingly. We'll use this as part of our release notes in monthly communications.
Please target your PR to 'master' branch.

Thanks for your contribution! Sharing is caring.

z3019494 commented 12 months ago

Updated readme.md with acknowledgements

z3019494 commented 12 months ago

Where do I electronically sign the CLA again? 😂

z3019494 commented 12 months ago

A second view sample has been added: Exam Bundle Tracker! :)

z3019494 commented 11 months ago

@tecchan1107 - I think I'm done with the edits to the various files. Hopefully I've done the pull request and other bits correctly? 🙈 (It's my first Github contribution anywhere!)

tecchan1107 commented 11 months ago

@z3019494 Awesome!!! It's perfect!!! I just have one concern, the images contain URLs and other users' names, is that ok? If this is a concern, I will test it later, and I can re-take the images at that time. (Of course, you can change it on your end, no problem!)

z3019494 commented 11 months ago

@z3019494 Awesome!!! It's perfect!!! I just have one concern, the images contain URLs and other users' names, is that ok? If this is a concern, I will test it later, and I can re-take the images at that time. (Of course, you can change it on your end, no problem!)

Hi @tecchan1107! The recordings I've done in the past probably contain the URLs totally unobscured, so it shouldn't be a problem, unless it somehow violates any of the Code of Conduct. The names should be fine as there aren't any email addresses - sadly I don't have a developer account to be able to have a fictitious Megan Bowen to illustrate the sample 😂

tecchan1107 commented 11 months ago

Thanks for the reply @z3019494 ! I understand! However, I may replace the images on my end, as I want to avoid problems as much as possible. Sorry about that. If that happens, I will contact you.

I'll check and test it. Please wait until the merge!

tecchan1107 commented 11 months ago

Hi @z3019494 ! I was checking the json of exam-bundle-tracker and found a column that is not mentioned in the README. The following columns were not listed in the README.

TopicContentSequence
TaskActive
LatestQuestionPaper
LatestSolutions

I'm sorry, but is it possible to modify the README or json?

z3019494 commented 11 months ago

Hi @z3019494 ! I was checking the json of exam-bundle-tracker and found a column that is not mentioned in the README. The following columns were not listed in the README.

TopicContentSequence

TaskActive

LatestQuestionPaper

LatestSolutions

I'm sorry, but is it possible to modify the README or json?

Oops - that conditional should be deleted. Let me go and remove it first (as it came from another sample!)

Line 685 now looks like this: "class": "sp-row-button ms-bgColor-grey ms-bgColor-neutralQuaternary--hover ms-fontColor-white--hover"

z3019494 commented 11 months ago

Hi @tecchan1107 ,

I've added a new column sample - though it might be better if you added the screenshot as I don't have the developer tenant 😅

This sample allows for a multi person, inline edit pill. Essentially pulled from the View samples, but replaced field names with @currentField instead.

tecchan1107 commented 11 months ago

Hi @z3019494 ! I modified the samples as follows.

multi-person-inlineedit-pill
- Added a sample image.
exam-bundle-tracker
- Replaced the sample image with a new one. (I was still personally afraid to post the image containing organizational information as a sample of the community, so I replaced it. Sorry about that.)
- Unified the internal names of columns not to include single-byte spaces.
student-class-learning-tracker
- Fixed layout corruption when screen width is narrowed.
- Replaced the sample image with a new one.
- Unified the internal names of columns not to include single-byte spaces.

Please check the changes and if there are no problems, I will merge them! (You can see the result of your changes from Files changed at the top of this page.)

z3019494 commented 11 months ago

Not a problem at all! Thanks heaps for trawling through the thousands of lines of code and prepping it up! 🙏 I've got no problem with the changes.

tecchan1107 commented 11 months ago

I merged them!

Also, they will be available in the Sample Solution Gallery today or tomorrow!

In addition, next time you want to pull request multiple samples, it would be helpful if you could separate branches and pull request for each of them. If you do not know how to do this, please feel free to let us know!

Once again, thank you so much for these amazing samples🤩!!!

tecchan1107 commented 11 months ago

If you are interested, please register for the following program. When you register, you will get a digital badge! M365 Platform & Power Platform Community Recognition Program

※Even if you register, it will not be distributed immediately. It will take some time before it is distributed.